Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Change cart example to not used shared signals #2437

Open
marvinhagemeister opened this issue May 20, 2024 · 0 comments
Open

Docs: Change cart example to not used shared signals #2437

marvinhagemeister opened this issue May 20, 2024 · 0 comments
Labels

Comments

@marvinhagemeister
Copy link
Collaborator

The example on https://fresh.deno.dev/docs/examples/sharing-state-between-islands shares signals on the module level which would mean that all requests would share the same signal. This is not a good default. We should rewrite the example so that each request gets a new cart signal and that the islands receive the cart as props.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant