Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecation: move @std/fmt/colors to @std/cli/styles #4694

Closed
wants to merge 2 commits into from
Closed

deprecation: move @std/fmt/colors to @std/cli/styles #4694

wants to merge 2 commits into from

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented May 8, 2024

Closes #4676

@iuioiua iuioiua requested a review from kt3k as a code owner May 8, 2024 06:18
@iuioiua iuioiua changed the title [unstable] deprecation: move @std/fmt/colors to @std/cli/styles deprecation: move @std/fmt/colors to @std/cli/styles May 8, 2024
@codecov Codecov
Copy link

codecov bot commented May 8, 2024 •
edited

Codecov Report

Attention: Patch coverage is 95.87156% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 91.49%. Comparing base (14f9cc6) to head (a5ccf3d).
Report is 3 commits behind head on main.

Files Patch % Lines
cli/styles.ts 95.71% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4694      +/-   ##
==========================================
+ Coverage   91.47%   91.49%   +0.02%     
==========================================
  Files         477      478       +1     
  Lines       37318    37528     +210     
  Branches     5325     5331       +6     
==========================================
+ Hits        34137    34338     +201     
- Misses       3125     3134       +9     
  Partials       56       56

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua closed this May 8, 2024
@iuioiua
Copy link
Collaborator Author

iuioiua commented May 8, 2024

I'm going to take another approach with this move.

@iuioiua iuioiua deleted the deprecate-fmt-colors branch May 8, 2024 06:32
@iuioiua iuioiua restored the deprecate-fmt-colors branch May 8, 2024 06:49
@iuioiua iuioiua deleted the deprecate-fmt-colors branch May 8, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
assert cli expect fmt http log testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

suggestion: move std/fmt/colors to std/cli/styles
1 participant
@iuioiua