New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NODE_DEBUG env var should be handled internally #23687
Labels
bug
Something isn't working
Comments
satyarohith
added a commit
that referenced
this issue
May 5, 2024
This patch allows implementors to use ext/node without the need to implement Deno.env API. Closes #23687
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This PR #23583 introduced a problem that env vars are read on startup (during the runtime creation). This is not great, because some embedders, might not provide API to read env vars or haven't captured env vars yet.
We need to read this env var explicitly during intialization (or accept it as a parameter for worker creation) and not rely on
Deno.env.get
API.The text was updated successfully, but these errors were encountered: