fix: serve handler error with 0 arguments #23652
Merged
+52
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
approved these changes
May 2, 2024
There was a problem hiding this comment.
LGTM. I'm OK to merge this, but it's unlikely that a user would realistically write a handler with no arguments and this helps avoid cases where a fetch export sets off a false positive for our deno serve hint message. If we're good with that tradeoff, we can merge it. :)
dsherret
reviewed
May 7, 2024
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "args": "serve --port 12345 main.ts", | |||
There was a problem hiding this comment.
Does deno serve find an open port? Maybe we should exclude it from the test? This port conflicts with another test.
There was a problem hiding this comment.
Is there a way to pick to an open port here? deno serve doesn't find an open port.
satyarohith
reviewed
May 16, 2024
Co-authored-by: Satya Rohith <[email protected]> Signed-off-by: Marvin Hagemeister <[email protected]>
satyarohith
changed the title
satyarohith
changed the title
bartlomieju
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23651