feat: make compatible with deno 1.7 #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeiea
force-pushed
the
deno-1.7
branch
2 times, most recently
from
c41e3df
to
29ab833
Compare
|
@jeiea It seems necessary to update the version number of Deno in ( |
|
Thanks for the comment. I'll try it few hours later. |
kt3k
reviewed
Feb 4, 2021
kt3k
reviewed
Feb 4, 2021
|
Commented on one point. Otherwise LGTM. |
kt3k
previously approved these changes
Feb 4, 2021
lucacasonato
reviewed
Feb 5, 2021
Co-authored-by: Luca Casonato <[email protected]>
kt3k
approved these changes
Feb 8, 2021
There was a problem hiding this comment.
LGTM
This looks ready to land now. What do you think? @lucacasonato @jeroenptrs
|
It does not work with deno 1.8 ( |
|
Never mind. It was my configuration miss. |
|
what about an approbal? we need this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #46.
I tested it with only my use cases. It's my first contribution to this repository so feel free to review or close.