Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the use of Bash on Windows for both Navi and fzf #874

Open
giggio opened this issue Jan 25, 2024 · 1 comment
Open

Enable the use of Bash on Windows for both Navi and fzf #874

giggio opened this issue Jan 25, 2024 · 1 comment
Labels
new feature New feature or request

Comments

@giggio
Copy link

giggio commented Jan 25, 2024

Is your feature request related to a problem? Please describe.
I'd like to be able to set Bash as my shell on Windows.
I share my cheat files between OSs, and I'd like to be able to use the same cheats and not need to rewrite them.

Describe the solution you'd like
I'd like to be able to configure Navi so that it works with other Shells.
Like so:

shell:
  # Shell used for shell out. Possible values: bash, zsh, dash, ...
  command: C:\Users\myuser\scoop\apps\msys2\current\usr\bin\bash.exe
  finder_command: C:\Users\myuser\scoop\apps\msys2\current\usr\bin\bash.exe

Describe alternatives you've considered
I don't know any.

Additional context
N/A.

@giggio giggio added the new feature New feature or request label Jan 25, 2024
giggio added a commit to giggio/cheats that referenced this issue Jan 25, 2024
The bash script is not working on Windows.
See denisidoro/navi#874
@giggio
Copy link
Author

giggio commented Jan 31, 2024

Some more context.
This seems to be the line causing one of my errors. For preview, that syntax won't work if you are using bash on Windows:

r#"(@echo.{{+}}{eof}{{q}}{eof}{name}{eof}{extra}) | {exe} preview-var-stdin"#,

Result at the top of the window is:

──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ /c/Users/user/scoop/apps/msys2/current/usr/bin/bash: line 1: @echo.NAVIEOFNAVIEOForiginal_dirNAVIEOF: command not found            │
│ /c/Users/user/scoop/apps/msys2/current/usr/bin/bash: line 1: C:Usersuserscoopappsnavi2.23.0navi.exe: command not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant