Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test test_verified_group_vs_delete_server_after is flaky #5201

Open
link2xt opened this issue Jan 21, 2024 · 4 comments
Open

Test test_verified_group_vs_delete_server_after is flaky #5201

link2xt opened this issue Jan 21, 2024 · 4 comments

Comments

@link2xt
Copy link
Collaborator

link2xt commented Jan 21, 2024

Attached is a log from CI:
flaky-test.txt

Maybe similar issue to #5191 but better understand what exactly happened.

@iequidoo iequidoo self-assigned this Jan 23, 2024
iequidoo added a commit that referenced this issue Jan 23, 2024
@iequidoo
Copy link
Collaborator

It happened also to me a couple of times, but i didn't understand the reason. In the log it looks like ac2 doesn't receive the vg-member-added message

@link2xt
Copy link
Collaborator Author

link2xt commented Jan 23, 2024

Maybe this message is delayed and arrives later?

@iequidoo
Copy link
Collaborator

Apparently it arrives immediately, but we still have some race in IMAP handling:
https://github.com/deltachat/deltachat-core-rust/actions/runs/7630255470/job/20797452090?pr=5209
After IO has been restarted, vg-member-added is received and the debug assertion fired.

@iequidoo
Copy link
Collaborator

As far as i can tell from the log, there's a race in Session::idle() somewhere between the call to self.server_sent_unsolicited_exists(context) and handle.wait_with_timeout(IDLE_TIMEOUT). So, either it's a problem in async_imap not interrupting the wait_for_timeout() call if new unsolicited responses have arrived or the server implementation not interrupting IMAP IDLE if new emails have arrived just before a receipt of the IDLE command.

iequidoo added a commit that referenced this issue Feb 5, 2024
iequidoo added a commit that referenced this issue Feb 6, 2024
iequidoo added a commit that referenced this issue Feb 7, 2024
iequidoo added a commit that referenced this issue Feb 7, 2024
@iequidoo iequidoo removed their assignment Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants