Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kube Downscaler] Create config block and use ConfigMap for it #582

Closed
fedaykin-b opened this issue May 10, 2024 · 2 comments
Closed

[Kube Downscaler] Create config block and use ConfigMap for it #582

fedaykin-b opened this issue May 10, 2024 · 2 comments

Comments

@fedaykin-b
Copy link

Hi,

I discovered your Kube Downscaler chart recently and decided to use it.

I'd like to propose something like shown below for configuring downscaler, instead of relying in raw definition of keys in env block:

# values.yaml

config:
  # default empty values to avoid impact in a installations and be backward compatible with previous usage of env block
  defaultUptime: ""
  defaultDowntime: ""
  dowscalePeriod: ""
  namespace:
    activeIn: ""
    inactiveIn: ""

the fields namespace.activeIn and namespace.inactiveIn are inspired in this helm-chart: https://github.com/hahow/kube-downscaler, I found it easy to understand. Those values would be read from a ConfigMap and used in the deployment.

If you approve this idea, I can make a PR.

@max-rocket-internet
Copy link
Member

Sure, PRs welcome 🙂

Copy link

This issue is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants