Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enum default values should not be forced. #1006

Open
iocanel opened this issue Jun 29, 2022 · 0 comments
Open

Enum default values should not be forced. #1006

iocanel opened this issue Jun 29, 2022 · 0 comments

Comments

@iocanel
Copy link
Member

iocanel commented Jun 29, 2022

Currently in dekorate we have almost 18 enums. Those enums are used in the dekorate annotations. In most cases the annotations define the default value and the rest of the code just applies whatever value is found in the config objects. This works fine for dekorate itself but has issues with downstream projects. Why? because a dekorator applying the default or overriden value will always be applied possibly clashing with dekorators registered downstream.

For example, with the given code we always register a dekorator that sets the image pull policy, wether the user selected a non default value or not. This is breaking downstream projects that use their own config model.

What should we do? Only register decorators when non default values are selected.

Note: This issue most probably applies to other types too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant