-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build script that creates necessary directories / files instead of platform-dependent Makefile #92
Comments
I am not wading into the waters on Windows and Make. It's nearly impossible to keep a Makefile functional for Windows without making it a nightmare for everyone else. So a |
Makefiles have never really had a great cross-platform story, unfortunately. Same for justfiles. Have a look at krustlet's justfile/justfile-windows story for example: https://github.com/deislabs/krustlet/blob/main/justfile-windows Lotta code duplication just to have a "cross-platform" build toolchain. |
So we seem to have a few options on the table:
|
We recently added support for building and running Wagi on Windows (#60) -- but because of the platform-dependent Makefile, you cannot
make run
on Windows.We should either add a separate target for Windows, or move the logic to create the directories and certificates in a
build.rs
script.Note that setting the log environment variables still needs to be in the Makefile, and that is going to have to be platform dependent.
The text was updated successfully, but these errors were encountered: