Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slight.exe doesn't run on WS2019 or WS2022 due to missing dlls #378

Open
jsturtevant opened this issue Apr 12, 2023 · 5 comments
Open

slight.exe doesn't run on WS2019 or WS2022 due to missing dlls #378

jsturtevant opened this issue Apr 12, 2023 · 5 comments
Labels
🐛 bug Something isn't working 🚧 maintainer issue An issue that is being tackled by maintainers

Comments

@jsturtevant
Copy link

Description of the bug
When running on Windows Server 2019/2022 slight doesn't run:

PS C:\Program Files\containerd\release> .\slight.exe -h
<no output>

To Reproduce
Run either WS2022 and WS2019

cmd /c ver
Microsoft Windows [Version 10.0.20348.1607]

install:

curl.exe -LO https://github.com/deislabs/spiderlightning/releases/download/v0.4.1/slight-windows-x86_64.tar.gz
tar.exe xvf .\slight-windows-x86_64.tar.gz
x release/slight.exe

image

Additional context

We may want to link the runtime for windows statically as many of the binaries. info in https://stackoverflow.com/a/44387312/697126

@jsturtevant jsturtevant added 🐛 bug Something isn't working 🚧 maintainer issue An issue that is being tackled by maintainers labels Apr 12, 2023
@jsturtevant
Copy link
Author

adding a .cargo/config.toml with

[target.x86_64-pc-windows-msvc]
rustflags = ["-C", "target-feature=+crt-static"]

seems to have fixed the issue with the vsruntime.dll loading but still getting ssl related library loading issues:

image

@jsturtevant
Copy link
Author

after running choco install openssl -y I am able to run it. We should look into alternatives for how openssl is used.

@Mossaka
Copy link
Member

Mossaka commented Apr 12, 2023

@jsturtevant I am not sure what's the best practices for how openssl should be used. Any suggestions?

I should point out that our Makefile has a command for install all deps on Windoes. Shall we make this more visiable for people trying to compile slight on their host?

@jsturtevant
Copy link
Author

it's not just compiling. If I try to install the released binary on a fresh machine, you will need this additional install of openssl which IMO isn't a great expereince.

I am not sure what's the best practices for how openssl should be used. Any suggestions?

I am not sure, I will need to look more deeply into how it is being used.

@D1esel-Dev
Copy link

D1esel-Dev commented Jul 8, 2023

Yes!! i just had an issue where there was no output aswell, now i fixed it because all i did was read this issue and installed openssl with choco:

PS C:\Users\zer0> choco install openssl -y
Chocolatey v2.1.0
Installing the following packages:
openssl
By installing, you accept licenses for the packages.
Progress: Downloading openssl 1.1.1.2100... 100%
openssl v1.1.1.2100 [Approved]
openssl package files install completed. Performing other installation steps.
Installing 64-bit openssl...
openssl has been installed.
WARNING: No registry key found based on 'OpenSSL-Win'
PATH environment variable does not have C:\Program Files\OpenSSL-Win64\bin in it. Adding...
WARNING: OPENSSL_CONF has been set to C:\Program Files\OpenSSL-Win64\bin\openssl.cfg
openssl can be automatically uninstalled.
Environment Vars (like PATH) have changed. Close/reopen your shell to
see the changes (or in powershell/cmd.exe just type refreshenv).
The install of openssl was successful.
Software installed to 'C:\Program Files\OpenSSL-Win64'
Chocolatey installed 1/1 packages.
See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

PS C:\Users\zer0> slight -?
error: unexpected argument '-?' found
Usage: slight.exe [OPTIONS]
For more information, try '--help'.

PS C:\Users\zer0> slight -h
Usage: slight.exe [OPTIONS]
Commands:
run Run slight providing a config and a module
secret Add a secret to the application
add Download a SpiderLightning interface
new Start a new Slight project
buildjs Build a JS Slight project
help Print this message or the help of the given subcommand(s)
Options:
-c, --config
-h, --help Print help
-V, --version Print version

PS C:\Users\zer0> slight new -n [email protected] rust && cd spidey
PS C:\Users\zer0\spidey>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🚧 maintainer issue An issue that is being tackled by maintainers
Projects
None yet
Development

No branches or pull requests

3 participants