Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add info about link between Color Coherence and Hybrid in "Animation Settings wiki" #860

Open
1 task done
Arkkotangens opened this issue Aug 25, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@Arkkotangens
Copy link

Arkkotangens commented Aug 25, 2023

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

Color coherence - Video input. This option will only work if any part of Hybrid mode is activated.

The problem: let's say i want to make a 2d redraw of my static or slowly moving video shots, i consider Hybrid as unnecessary. Controlnets Tile and SoftEdge with vid path do all heavy lifting, with TemporalNet helping with consistency.

I assume the option "Video input" will help with color consistency. I have video init, i want some original colors of my video in my generations. But apparently Coherence tab is somewhat a part of Hybrid, and Video input will work only with either Hybrid Comp or Hybrid Motion activated. It's mentioned only in reallybigname's memo, and not all people will read it if they choose not to use Hybrid.

And there is no info about that in https://github.com/deforum-art/sd-webui-deforum/wiki/Animation-Settings. "color_coherence" is just a blank line, altough it's a pretty important option.

I suggest to add some info there. Something like "Color coherence - Video input will work only with Hybrid video mode activated".
And some explanation about difference between LAB and other options would be great. Especially "Legacy colormatch" with hint "use with CN's Tile".

Proposed workflow

  1. Go to Color coherence
  2. Choose "Video Input"
  3. Additional info appears "Video input mode works only when either Hybrid Comp or Hybrid Motion is activated"

Additional information

No response

Are you going to help adding it?

I can add a line about a link between Color coherence and Hybrid to wiki, but i have no clue about the difference between LAB and HSV and so on.

@Arkkotangens Arkkotangens added the enhancement New feature or request label Aug 25, 2023
@reallybigname
Copy link
Member

It is mentioned in the hybrid documentation, but I don't have access to the wiki, or I would update it. The link to this document was put in the wiki, but nobody ever updated the wiki using the document. Frankly, if I had permission to do it and wiki access, I would fix up a bunch of that stuff... kab? @kabachuha

https://docs.google.com/document/d/1I9zJfmmJd9l6aEdPa_JZBbciOw-6r2CsWcesGLbCb-8/edit

As for the legacy color mode, people just saw that if using cn tile as a strength replacement that the color was degraded with the new color behavior, so people would use the legacy behavior. Whereas, with most other animations, the new behavior is better.

@kabachuha
Copy link
Member

Added the write access, idk why it's not enabled by default for the members

@reallybigname
Copy link
Member

Oh, I never tried! Maybe I did have access! I thought someone needed to allow it. Anyway, even if I did have access, I still wanted to get permission or tell someone that I could update thewiki. Cool, once I'm done with some stuff, I'll see about updating it!

@reallybigname
Copy link
Member

By the way, in my local development environment, I've just separated out the color coherence so that if you select video, it will extract the video even if you aren't using any hybrid features. I made a bunch of other cool changes too, but I'm also doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants