Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for invalid paths #219

Closed
ronag opened this issue Aug 21, 2016 · 3 comments
Closed

Check for invalid paths #219

ronag opened this issue Aug 21, 2016 · 3 comments

Comments

@ronag
Copy link

ronag commented Aug 21, 2016

Breaking out from #214.

Json paths should be checked for validity. Currently the behaviour for invalid paths is pretty much undefined.

@yasserf yasserf added this to the 3.0 milestone Oct 6, 2017
@yasserf yasserf added ready and removed roadmap labels Nov 28, 2017
@yasserf yasserf modified the milestones: 3.0, 4.0 Jun 4, 2019
@yasserf
Copy link
Contributor

yasserf commented Jun 4, 2019

I would probably suggest we deprecate our path notation (which is built around our random thing) and use a third party library like jsonpath. Only issue is its almost 7000 lines, so might be just add an option in V4 to allow custom JSON path libraries.

This would need to be used in both the server and JS, but the server can easily take the extra 80kb weight as a dependency.

@yasserf
Copy link
Contributor

yasserf commented Sep 19, 2019

Yeah I’m still 100% for getting rid of our custom paths and using an actual json path implementation. raising this as a V5 issue

@yasserf
Copy link
Contributor

yasserf commented Feb 21, 2020

Closing in favour of deepstreamIO/deepstream.io#1046

@yasserf yasserf closed this as completed Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants