Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileTypeRouter should get mime type from ByteStream mime type attribute instead of `meta #7633

Closed
1 task done
wochinge opened this issue May 2, 2024 · 0 comments · Fixed by #7681
Closed
1 task done
Assignees
Labels
P1 High priority, add to the next sprint

Comments

@wochinge
Copy link
Contributor

wochinge commented May 2, 2024

Describe the bug
Looking at this code here:

The ByteStream class has an attribute mime_type. We should rather using this than using the metadata for this.

Error message
None

Expected behavior
Use mime_type field instead of meta (or make this configurable)

Additional context
Add any other context about the problem here, like document types / preprocessing steps / settings of reader etc.

To Reproduce
Steps to reproduce the behavior

FAQ Check

System:

  • OS:
  • GPU/CPU:
  • Haystack version (commit or version number): 2
  • DocumentStore:
  • Reader:
  • Retriever:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority, add to the next sprint
Projects
None yet
3 participants