-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.0 tbl_uvregression()
#1641
Comments
Just a quick comment about But we could also maybe consider refactoring
At that stage, Would it be an idea to explore? Should |
Hmmmm, good points. Maybe it's easier to simply keep supporting the functions as they are? The functions are pretty simple and probably won't be a burden to maintain. #' @rdname plot
#' @export
plot.tbl_regression <- function(x,
remove_header_rows = TRUE,
remove_reference_rows = FALSE, ...) {
check_dots_empty(error = function(e) inform(c(e$message, e$body)))
assert_package("ggstats", fn = "plot.tbl_regression()")
df_coefs <- x$table_body
if (isTRUE(remove_header_rows)) {
df_coefs <- df_coefs %>% filter(!.data$header_row %in% TRUE)
}
if (isTRUE(remove_reference_rows)) {
df_coefs <- df_coefs %>% filter(!.data$reference_row %in% TRUE)
}
df_coefs %>%
ggstats::ggcoef_plot(exponentiate = x$inputs$exponentiate, ...)
}
#' @rdname plot
#' @export
plot.tbl_uvregression <- plot.tbl_regression |
I agree with that these plot functions are easy to maintain. Regarding a more general implementation of |
Do you think that in v2.0 it would be possible to consider the implementation of EDIT: I'm ready to help with the implementation but I don't really know where to start... |
Hi again @ABohynDOE , The way we're constructing the models in uvregression will be based off of this function. If you'd like to take a go at adding an S3 method for imputed data frames, while keeping the same API, please feel free. |
Hi again ! Thanks for the answer, I'll wait for the maintenance and then I'll try to implement a method for imputed dfs. |
Add function to package
tbl_uvregression()
add_n.tbl_uvregression()
add_global_p.tbl_uvregression()
add_nevent.tbl_uvregression()
plot.tbl_uvregressions()
The text was updated successfully, but these errors were encountered: