-
-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not explicitly set the backdrop_drupal_compatibility and update_free_access settings in settings.ddev.php #6090
Comments
klonos
changed the title
Do not explicitly enable the backdrop_drupal_compatibility setting in settings.ddev.php
Do not explicitly enable the backdrop_drupal_compatibility and update_free_access settings in settings.ddev.php
Apr 13, 2024
klonos
changed the title
Do not explicitly enable the backdrop_drupal_compatibility and update_free_access settings in settings.ddev.php
Do not explicitly set the backdrop_drupal_compatibility and update_free_access settings in settings.ddev.php
Apr 13, 2024
klonos
added a commit
to klonos/ddev
that referenced
this issue
Apr 13, 2024
…ity and update_free_access settings Fixes ddev#6090
PR for this here: #6091 (I hope I did everything right - this is my first PR for this project). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
Expected Behavior
With a Backdrop DDEV recipe, when setting
backdrop_drupal_compatibility
orupdate_free_access
insettings.php
orsettings.local.php
(which unlike Drupal is provided by default OOTB in Backdrop), the Drupal compatibility layer should respect that setting.Actual Behavior
Because
backdrop_drupal_compatibility
andupdate_free_access
are also explicitly set insettings.ddev.php
(see https://github.com/ddev/ddev/blob/master/pkg/ddevapp/drupal/backdrop/settings.ddev.php#L21), and because the DDEV settings file is loaded last, the desired settings as configured for the site never take (they are always overridden by the DDEV settings.php file). That is not expected behavior, and it should be left up to the defaults set by your Backdrop version (thebackdrop_drupal_compatibility
setting for instance is enabled by default in Backdrop 1.x but planned to be disabled by default in 2.x).Steps To Reproduce
settings.php
file or thesettings.local.php
file and set$settings['backdrop_drupal_compatibility'] = FALSE;
.settings_get('backdrop_drupal_compatibility')
(for instance using the devel module anddpm()
or something) -> regardless of how that setting is configured, it is always returned asTRUE
👎🏼The text was updated successfully, but these errors were encountered: