Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined names in Python code #40

Open
cclauss opened this issue Sep 12, 2019 · 0 comments
Open

Undefined names in Python code #40

cclauss opened this issue Sep 12, 2019 · 0 comments

Comments

@cclauss
Copy link

cclauss commented Sep 12, 2019

flake8 testing of https://github.com/ddbourgin/numpy-ml on Python 3.7.1

$ flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics

./numpy_ml/rl_models/trainer.py:75:61: F821 undefined name 'smooth_tot'
            smooth_tot = tot_rwd if ep == 0 else (1 - sf) * smooth_tot + sf * tot_rwd
                                                            ^
./numpy_ml/neural_nets/models/w2v.py:303:38: F821 undefined name 'smooth_loss'
                smooth_loss = 0.99 * smooth_loss + 0.01 * loss if ix > 0 else loss
                                     ^
./numpy_ml/neural_nets/layers/layers.py:1845:14: F632 use ==/!= to compare str, bytes, and int literals
        elif self.pool is "sum":
             ^
./numpy_ml/neural_nets/layers/layers.py:1848:14: F632 use ==/!= to compare str, bytes, and int literals
        elif self.pool is "mean":
             ^
2     F632 use ==/!= to compare str, bytes, and int literals
2     F821 undefined name 'smooth_loss'
4

E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. These 5 are different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety.

  • F821: undefined name name
  • F822: undefined name name in __all__
  • F823: local variable name referenced before assignment
  • E901: SyntaxError or IndentationError
  • E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant