-
Notifications
You must be signed in to change notification settings - Fork 2
Party object / displayedAddress field #12
Comments
@enriquesempe I think that's a fair suggestion. Especially if it is in addition to the separate fields so the sender can decide what to send depending on the available information. This is indeed also inline in what has been discussed previously. |
@enriquesempe below a proposal (I have not update the OAS yet) I added a displayedAddress to the address object all fields are optional. This way we do not loose the capability to send a structured address if needed. A Max Length of 500 does seem quite large, do you have real life examples where such a large displayedAddress is needed? {
"eBLPlatformIdentifier": "[email protected]",
"partyName": "Asseco Denmark",
"taxReference1": "CVR-25645774",
"taxReference2": "CVR-25645774",
"publicKey": "eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCIsImtpZCI6IkFzaW",
"address": {
"displayAddress": "Kronprincessegade 54, 5. sal, 1306 København Denmark",
"name": "Henrik",
"street": "Kronprincessegade",
"streetNumber": "54",
"floor": "5. sal",
"postCode": "1306",
"city": "København",
"stateRegion": "N/A",
"country": "Denmark"
},
"partyContactDetails": [
{
"name": "Henrik",
"phone": "+45 33364660",
"email": "[email protected]",
"url": "https://www.dcsa.org"
}
],
"identifyingCodes": [
{
"DCSAResponsibleAgencyCode": "SMDG",
"partyCode": "MSK",
"codeListName": "LCL"
}
]
} |
We should consider making this an optional choice (OAS oneOf), otherwise what if the structured address and displayed address contain different information? |
Agree with considering this as an optional choice, it's up to the user/service provider to decide how they will be completing this information |
Ok with this proposal. Regarding the Max Length of 500, it is true that it might seem quite large, we could consider 250 instead. On our side, the vast majority of the address are below 250 characters. Those out of this group might be because in some situations they might be adding some other information on this field such as telephone numbers, tax id numbers, etc..., which is not correct. |
Would suggest making it 255 (default varchar length for many of the databases available) |
I would suggest adding a field like "displayedAddress" with a maxLength of 500 in the party object, to complete the whole description of the address rather than having only each independent field such as street, streetNumber, floor, etc
The text was updated successfully, but these errors were encountered: