Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window for "Select Data Source" disappears seconds after switching tabs, right as you're selecting a data source #30184

Open
c-o-m-m-a-n-d-e-r-d-a-t-a opened this issue May 10, 2024 · 3 comments
Labels
bug xf:connection xf:sql editor SQL Editor and Editor Services like autocompletion, highlighting, folding, formatting, etc. xf:ui UI-related issues xp:normal

Comments

@c-o-m-m-a-n-d-e-r-d-a-t-a

Description

As the title says, the window for "Select Data Source" disappears seconds after switching tabs, right as you're selecting a data source. So you switch tabs, go to use a different data source for the query, and begin typing the name of the data source to select it (which is a brilliant feature), but then some refresh occurs in the background and the "Select Data Source" window disappears, and suddenly you're typing in the main query window. Only costs seconds, but seems to happen very often and is somewhat maddening.

DBeaver Version

Community Edition 24.0.4

Operating System

Windows 10 22H2

Database and driver

MS SQL 2016; Microsoft JDBC Driver for SQL Server 12.4

Steps to reproduce

Switch to any other open tab
Hit CTRL-9 to open the "Select Data Source" window
begin typing to filter the existing saved data sources
as you type, the window will disappear, and you'll be typing in the main query window, accidentally.
You now have to hit CTRL-9 again to restart the Data Source selection process

Additional context

No response

@E1izabeth
Copy link
Member

Unfortunately, I can't reproduce the issue. Could you turn these settings on and record a small video showing the issue? All keys pressed and mouse clicks will be shown on the screen and we could see the issue roots
image

@c-o-m-m-a-n-d-e-r-d-a-t-a
Copy link
Author

output4

I think it's because when you switch to an existing tab (which you hadn't yet connected that server / tab yet this session) then it does a background connect, but allows you to open the data source switcher before the connection completes, yet kills the data source switcher at the point that the connection does complete. You can see in the bottom right of the screen the new connection being connected when you switch tabs.

I'll admit I had to go a bit quicker than normal in this demo, but in a normal day I find this happens quite a lot, without trying to go any faster than normal. When you're in the zone, you go quite quick, right?

@E1izabeth
Copy link
Member

Thank you

@E1izabeth E1izabeth added wait for review xf:connection xf:sql editor SQL Editor and Editor Services like autocompletion, highlighting, folding, formatting, etc. xp:normal xf:ui UI-related issues and removed wait for response can't reproduce wait for review labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug xf:connection xf:sql editor SQL Editor and Editor Services like autocompletion, highlighting, folding, formatting, etc. xf:ui UI-related issues xp:normal
Projects
None yet
Development

No branches or pull requests

2 participants