Remove implicit bitmap to png conversions #301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bitmap library used for this does not support the various bitmap formats in the wild. This is also very confusing behaviour for a user of the pre-v2 version of govips, which was able to handle all the various bmp files Closes davidbyttow#300
|
Hey @jhford-scout24 doesn't look like it's passing |
|
Hey @jhford-scout24 can you make necessary updates to get passing tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bitmap library used for this does not support the various bitmap
formats in the wild. This is also very confusing behaviour for a user of
the pre-v2 version of govips, which was able to handle all the various
bmp files
Closes #300
I can't run the test suite on my local machine, so I'm pushing here to see if the tests run successfully