Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setter to enable encoder intent for hardware encoders. #458

Open
davetcc opened this issue Mar 16, 2024 Discussed in #457 · 2 comments
Open

Add setter to enable encoder intent for hardware encoders. #458

davetcc opened this issue Mar 16, 2024 Discussed in #457 · 2 comments
Assignees
Milestone

Comments

@davetcc
Copy link
Owner

davetcc commented Mar 16, 2024

Discussed in #457

Originally posted by AndyB117 March 13, 2024
I use rotary encoder. And I connect pins so that when I turn rotary clockwise than navigate UP to menu tree, counter-clockwise - DOWN. But when I edit values in menu items turning clockwise decreases the value rather than increasing it!
In my opinion this is not logical. People usually associate the concepts UP and INCREASE. DOWN and DECREASE. But not vice versa.
How can I make it so that menu navigation UP and INCREASING values are achieved by turning to one side?

@davetcc davetcc added this to the 4.3.x milestone Mar 16, 2024
@davetcc davetcc self-assigned this Mar 16, 2024
@davetcc
Copy link
Owner Author

davetcc commented Mar 16, 2024

This is a very simple addition to enable the intent that already is used by the up/down encoder.

@davetcc
Copy link
Owner Author

davetcc commented Mar 16, 2024

For example, once this code is committed calling switches.getEncoder(0)->setHonourIntent(true); will make the encoder change direction to allow for situations where there is a different direction between navigating and editing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant