Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Designer: once saved, focus goes to root #283

Open
luwenjin opened this issue Jan 13, 2023 · 4 comments
Open

Designer: once saved, focus goes to root #283

luwenjin opened this issue Jan 13, 2023 · 4 comments
Labels
awaiting-feedback generator-ui Issues in Generator UI question Further information is requested

Comments

@luwenjin
Copy link

luwenjin commented Jan 13, 2023

Designer version: 3.0.0

If I was editing an menu, and saved the project, the designer will automatically select the root, and I had to select back the menu I was editing.

I think, saving shouldn't change the selected menu.

This also happens when I generate code.

@davetcc davetcc added generator-ui Issues in Generator UI awaiting-feedback question Further information is requested labels Feb 17, 2023
@davetcc
Copy link
Owner

davetcc commented Feb 17, 2023

As per the other chat, this does not happen on macOS Ventura or Windows 11, can you please provide the environment as there's something different here.

The focus returns to the tree (not root but the last selected item), but simply pressing Esc goes back to the editor.

@luwenjin
Copy link
Author

I've tried it on ventura+designer 3.1

the simpleU8g2.emf from the examples works fine.
But my emf has the bugs I've posted, I had also looked up the logs, found no errors, here is a sample from the log file:

2023-02-20 09:28:22 信息 com.thecoderscorner.menu.editorui.project.FileBasedProjectPersistor save Save file starting for: /Users/luwenjin/Projects/luwenjin/SoccerBar/src/ui/SoccerBar.emf
2023-02-20 09:28:22 信息 com.thecoderscorner.menu.editorui.uimodel.CurrentProjectEditorUIImpl createPanelForMenuItem creating new panel for menu item editing 0
2023-02-20 09:28:23 信息 com.thecoderscorner.menu.editorui.uimodel.CurrentProjectEditorUIImpl createPanelForMenuItem creating new panel for menu item editing 85
2023-02-20 09:28:23 信息 com.thecoderscorner.menu.editorui.uimodel.CurrentProjectEditorUIImpl lambda$createPanelForMenuItem$3 created panel UITextMenuItem
2023-02-20 09:28:24 信息 com.thecoderscorner.menu.editorui.uimodel.CurrentProjectEditorUIImpl createPanelForMenuItem creating new panel for menu item editing 93
2023-02-20 09:28:24 信息 com.thecoderscorner.menu.editorui.uimodel.CurrentProjectEditorUIImpl lambda$createPanelForMenuItem$3 created panel UIBooleanMenuItem
2023-02-20 09:28:26 信息 com.thecoderscorner.menu.editorui.project.FileBasedProjectPersistor save Save file starting for: /Users/luwenjin/Projects/luwenjin/SoccerBar/src/ui/SoccerBar.emf
2023-02-20 09:28:26 信息 com.thecoderscorner.menu.editorui.uimodel.CurrentProjectEditorUIImpl createPanelForMenuItem creating new panel for menu item editing 0
2023-02-20 09:28:27 信息 com.thecoderscorner.menu.editorui.uimodel.CurrentProjectEditorUIImpl createPanelForMenuItem creating new panel for menu item editing 93
2023-02-20 09:28:27 信息 com.thecoderscorner.menu.editorui.uimodel.CurrentProjectEditorUIImpl lambda$createPanelForMenuItem$3 created panel UIBooleanMenuItem

I tried to trim my project down to see which branch cause the bugs,
Here is the minimal project that can reproduce the bugs.

bug.emf.zip

@davetcc
Copy link
Owner

davetcc commented Mar 27, 2023

As per the other issue this is not recreatable on either my Windows or MacOs based machine. Can you provide more detail, I'm measuring this by the selected item in the tree's UI, are you using a different measure?

@luwenjin
Copy link
Author

Sorry, I don't understand the meaning of "measure" in the context, could you please express it in another way?

Here is a screen recording of the bug.

Filmage.2023-03-29_225921.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-feedback generator-ui Issues in Generator UI question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants