Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test command coverage for networking use cases #382

Open
noaabarki opened this issue Jan 17, 2022 · 8 comments
Open

Improve test command coverage for networking use cases #382

noaabarki opened this issue Jan 17, 2022 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers testing This issue or pull request is related to testing up for grabs Looking for a contributor to take this task
Projects

Comments

@noaabarki
Copy link
Contributor

Describe the solution you'd like
Add tests for networking failures flows in test command datree test <path>

Basic use cases to cover:

Failed to create evaluation

  • should create evaluation → meaning to call CreateEvaluation
  • should not request evaluation → meaning not to call Evaluate
  • should print mocked errors.

Failed to request evaluation

  • should create evaluation → meaning to call CreateEvaluation
  • should request evaluation → meaning to call Evaluate with returned evaluationID
  • should print mocked errors.

Requirements
Golang basic level.

@noaabarki noaabarki added enhancement New feature or request up for grabs Looking for a contributor to take this task testing This issue or pull request is related to testing labels Jan 17, 2022
@github-actions github-actions bot added this to To Do in Datree Jan 17, 2022
@adifayer adifayer moved this from To Do to Selected for development in Datree Feb 2, 2022
@noaabarki noaabarki added the good first issue Good for newcomers label Feb 24, 2022
@Kanika637
Copy link

I would like to work on this @noaabarki

@noaabarki
Copy link
Contributor Author

@Kanika637, it's yours 💪🏻

@noaabarki noaabarki added the WIP Working in progress (will be deployed soon) label Apr 18, 2022
@adifayer
Copy link
Contributor

@Kanika637 Are you still working on this issue, or can we reassign it?😊

@Kanika637
Copy link

Hey @adifay, actually I could not get hold of the issue. You can reassign it, sorry for the inconvenience.

@adifayer adifayer removed the WIP Working in progress (will be deployed soon) label May 26, 2022
@KiranSatyaRaj
Copy link

Hey @noaabarki, can you send me the slack invitation, I need to troubleshoot some issues I have while installing datree, and also to discuss this GitHub issue, I want to take it up.

@noaabarki
Copy link
Contributor Author

Hi @KiranSatyaRaj, you got it!

This is the invite URL for Datree Slack channel: https://join.slack.com/t/datreecommunity/shared_invite/zt-1kaxe67uc-o0uO3EuK3kxjV3PSeqe~ZA.

@KiranSatyaRaj
Copy link

Hey @noaabarki, I didn't work with Git much and had less idea on how to deal with it, all these days I was learning Git and blogging it along the way, I'm back now and will start working on this issue, so far I got a hold of this if there's anything I'm stuck with I'll get back to you, thanks Noaa

@KiranSatyaRaj KiranSatyaRaj removed their assignment Jan 17, 2023
@Kanika637 Kanika637 removed their assignment Mar 12, 2023
@Bharadwajshivam28
Copy link

Bharadwajshivam28 commented Mar 3, 2024

Hey @noaabarki Can I work on this if no one is working?

What I understand from the issue is that-

We have to add tests based on-
Test case 1st-
A scene where evaluation fails
use the function CreateEvaluation and make it return an error

Test case 2nd-
system does not proceed to request evaluation as our evaluation failed
check that Evaluate function not gets called
Check that test gets captured and prints expected error

Test case 3th-
Creating an evaluation is successful
Call Evaluate function with evaluationID

having a small doubt in which directory I need to create the test file? Like We need to have a test file in which the test scene will be there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers testing This issue or pull request is related to testing up for grabs Looking for a contributor to take this task
Projects
Datree
Selected for development
Development

No branches or pull requests

5 participants