[WIP] Solve cross-platform import problem on MacOS build #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stuart Preston <[email protected]>
SQLDBAWithABeard
previously requested changes
Jan 2, 2023
|
|
|
You are right and I can't read :-) |
|
Yes I have to fix some paths on those other functions |
|
@stuartpreston I have updated a few other files as well |
|
and I have added the PR workflow so that it will run the tests too :-) |
Closed
|
Convert-Path shouldn't be required to support PowerShell on Mac or Linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #909
This change might solve the problem with the MacOS build.
Note: Unfortunately I encountered further errors in the build on my local machine to do with the New-Json function either not correctly establishing the path to the test repo I'm likely missing a dependency since Get-CheckRepo isn't available on my machine so submitting this PR first to see if it gets us any further.