Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine consume input entries and output them into commands #731

Open
Tracked by #724
drmingdrmer opened this issue Mar 21, 2023 · 1 comment
Open
Tracked by #724

Engine consume input entries and output them into commands #731

drmingdrmer opened this issue Mar 21, 2023 · 1 comment

Comments

@drmingdrmer
Copy link
Member

drmingdrmer commented Mar 21, 2023

Engine should consume input entries instead of hold references to elements in the input entries buffer.
And Engine should output the actual entries that needs to be written to the store, instead of just providing the index of entries in the input buffer.

This approach eliminates the risk of errors that may occur when managing input cursor separately from the input buffer.

@drmingdrmer drmingdrmer changed the title should output the actual entries that needs to be written to the store, instead of just providing the index of entries in the input buffer. This approach eliminates the risk of errors that may occur when managing input cursor separately from the input buffer. Engine consume input entries and output them into commands Mar 21, 2023
@github-actions
Copy link

👋 Thanks for opening this issue!

Get help or engage by:

  • /help : to print help messages.
  • /assignme : to assign this issue to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant