Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix error capture of mulit statement transaction in mysql session #15583

Merged
merged 2 commits into from
May 20, 2024
Merged

chore: fix error capture of mulit statement transaction in mysql session #15583

merged 2 commits into from
May 20, 2024

Conversation

SkyFan2002
Copy link
Member

@SkyFan2002 SkyFan2002 commented May 20, 2024 •
edited

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

MySQL implementation did not capture all errors, resulting in transactions not being rolled back when errors occurred.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label May 20, 2024
@SkyFan2002 SkyFan2002 marked this pull request as ready for review May 20, 2024 12:57
@SkyFan2002 SkyFan2002 requested review from dantengsky, youngsofun, PsiACE and Xuanwo and removed request for PsiACE May 20, 2024 12:58
Xuanwo
Xuanwo approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dantengsky dantengsky added this pull request to the merge queue May 20, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request May 20, 2024
@BohuTANG BohuTANG merged commit 776fbf8 into datafuselabs:main May 20, 2024
75 checks passed
dantengsky added a commit to dantengsky/fuse-query that referenced this pull request May 20, 2024
@dantengsky
chore: rm http handlers constraints from logic test
bed77f4 
since pr datafuselabs#15583 fix it
BohuTANG pushed a commit that referenced this pull request May 20, 2024
@dantengsky @SkyFan2002
fix: consume stream inside explicit txn (#15582)
17e412f 
* fix: consume stream inside explicit txn

Consuming stream should respects the semantics of txn

* only allows "with consume" in query (and explain)

* cargo fmt

* fix logic test

* tweak logic test

* add logic test

* chore: rm http handlers constraints from logic test

since pr #15583 fix it

---------

Co-authored-by: sky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@dantengsky dantengsky dantengsky approved these changes

@PsiACE PsiACE PsiACE approved these changes

@youngsofun youngsofun Awaiting requested review from youngsofun

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: explicit txn is not handled properly in mysql handler
5 participants
@SkyFan2002 @Xuanwo @dantengsky @PsiACE @BohuTANG