Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endless loop in query history implementation #543

Open
matejcermak opened this issue Feb 14, 2024 · 1 comment
Open

Endless loop in query history implementation #543

matejcermak opened this issue Feb 14, 2024 · 1 comment

Comments

@matejcermak
Copy link

if 'next_page_token' not in json or not json['next_page_token']:
return

Hi, I was trying to use query history API to fetch all queries that were made last # days. Unfortunately the pagination within the loop seems to be endless even if there is no more results to fetch as next_page_token is always present. Is this on purpose?

Ended up reengineering the loop to finish when has_next_page is False and that worked for my use case.

@mgyucht
Copy link
Contributor

mgyucht commented Feb 19, 2024

Thanks for reporting. I've raised this issue with the responsible team. In general, APIs must not include a next_page_token in the response if there are no more pages, so I've asked if that change can be made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants