Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations #559

Open
alexanderby opened this issue Jun 12, 2018 · 64 comments
Open

Translations #559

alexanderby opened this issue Jun 12, 2018 · 64 comments

Comments

@alexanderby
Copy link
Member

alexanderby commented Jun 12, 2018

How to improve a translation

  • Open locales folder.
  • Find a language code you know.
  • Edit messages directly on GitHub (or on local machine if you are familiar with Git) under @message_id. Please, preserve the lines count.
  • Submit a pull request.

How to add a new translation

  • Leave a comment that you are going to add a new translation, check that somebody else has not started it yet.
  • See the list of supported Chrome locales.
  • Download English locale.
  • Rename the file into corresponding language code (use dashes for file name if necessary, e.g. zh-TW.config.
  • Edit messages under @message_id. Please, preserve the lines count.
  • Open locales folder.
  • Click Create new file or Upload files.
  • Submit a pull request.

Help page translations

  • Help page translations are listed here.
  • Follow the same steps described above.
@giorgiogamberini
Copy link

Hi guys, gonna start the Italian translation.
Submitting a pull request by the end of the day.

@alexriabtsev
Copy link

Hi, team! uk (Ukrainian) translation going to be done.

@alexanderby
Copy link
Member Author

@alexriabtsev Great, here is Belarusian and Russian for your reference.

@svemal
Copy link
Contributor

svemal commented Oct 31, 2018

Gonna add a Norwegian (no) translation

@alexanderby
Copy link
Member Author

Thank you @svemal, great work! It will be included in next release.

@PsiPhiTheta
Copy link

PsiPhiTheta commented Mar 20, 2019

currently working on french translation for help page ... DONE. PR submitted

@UchihaSR
Copy link
Contributor

can i do it for indian languages?

@alexanderby
Copy link
Member Author

Hi @UchihaSR, here is my Hindi translation using Google Translate, feel free to suggest a fix https://github.com/darkreader/darkreader/blob/master/src/_locales/hi.config

@UchihaSR
Copy link
Contributor

Greeting @alexanderby your translation seems to be pretty good, need to do some correction with store listing section for grammatical error and small changes in a few places. shall i make changes and then send a PR.

@reymon359
Copy link

Hi! I just finished the spanish translation for the help on darkreader.org

@alexanderby
Copy link
Member Author

@UchihaSR You can edit this file online (this will automatically create a fork), then you can open a pull request in one click. Or you can use Git to make your own fork manually.

@alexanderby
Copy link
Member Author

@reymon359 Thank you for the translation. This requires some manual changes in the app and publishing an update, to make this help page viewed to users from Spain by default. So I'm going to make it this week.

@Underday
Copy link

Underday commented Sep 3, 2019

Can you give me permission for Turkish translation?

@alexanderby
Copy link
Member Author

@Underday Just merged the pull request with Turkish translation made by another user, please have a look https://github.com/darkreader/darkreader/blob/master/src/_locales/tr.config

@alexanderby alexanderby pinned this issue Sep 12, 2019
@Underday
Copy link

@Underday Just merged the pull request with Turkish translation made by another user, please have a look https://github.com/darkreader/darkreader/blob/master/src/_locales/tr.config

Oh, okay thnx

@reiscigit
Copy link

Hi, I have finished the Traditional Chinese translation for the Help page.

@alexanderby
Copy link
Member Author

Hi @reiscigit, you need to create a Pull Request in this repository https://github.com/darkreader/darkreader.org

@alexanderby
Copy link
Member Author

@reiscigit Please see my comment. It would be better use dashes for file names.

@reiscigit
Copy link

Hi, I've add a Chinese Simplified translation for the Help page. This is the PR.

@alexanderby
Copy link
Member Author

@reiscigit This is a big piece of work, thank you!

@june07
Copy link

june07 commented Oct 18, 2019

I'm curious about the format of the locale files .config... I see these are converted to messages.json files (which I'm used to) by the build process. Is this a common standard or specific to this project? Is there an easy/proven way to go backwards (i.e. convert the messages.json to .config). Thanks.

@FaelLiberatori
Copy link

FaelLiberatori commented Nov 5, 2019

I'm working on the help page Brazilian Portuguese translation. Edit: Done! PR

@Matin-A
Copy link
Contributor

Matin-A commented Nov 8, 2019

Hi, I translated to Farsi/Persian. I'm new to GitHub so i'm gonna try to follow the steps above.
Please help me if i done something wrong.
Also i believe there might be some visual issues since Farsi is RTL, so contact me if there were any issue.

I'm providing this with my translation just in case i wasn't able to pull request. ¯_(ツ)_/¯
fa-IR.txt

Edit: I did pull request. (See not too hard :))

@kartikcho
Copy link
Contributor

kartikcho commented Dec 26, 2019

Hi, I'm working on a Swedish translation and I'll add it soon.
Edit: #1861 Made a PR!

@norkko
Copy link
Contributor

norkko commented Jan 8, 2020

#1884 created new PR for swedish locale.

@alexanderby
Copy link
Member Author

@kartik918 @august-norkko Thank you guys.

Sorry for the delay, the first PR has a problem with CRLF line endings. I will merge your translations and publish soon.

@wojtekmaj
Copy link

Added lots of new localized strings of the new UI in #3237.

@tusharsadhwani
Copy link
Contributor

So the release tab says last release for this extension was 2 years ago. The readme says certain files are only updated when a new version is pushed. How long before a new release?

@Gusted
Copy link
Contributor

Gusted commented Sep 23, 2020

So the release tab says last release for this extension was 2 years ago. The readme says certain files are only updated when a new version is pushed. How long before a new release?

We actually don't use the release tab anymore but rather the extensions stores itself. Their is still a git tag to milestone all version.

@Sandr-aa
Copy link

At "de.config", line 57, is a wrong translation.
It says "Activieren", but it should be called "Aktivieren".
Sorry, I do not know how to edit these files.

@Gusted
Copy link
Contributor

Gusted commented Jan 20, 2021

At "de.config", line 57, is a wrong translation.
It says "Activieren", but it should be called "Aktivieren".
Sorry, I do not know how to edit these files.

You can use this link to edit the file and submit an PR.

@kizule
Copy link
Contributor

kizule commented Jan 30, 2021

Hello. I would like to add translations for the Serbian language. But it has two variants, Cyrillic and Latin. Which locale code I should use for providing translations on both variants?

@alexanderby
Copy link
Member Author

Hi @kizule. What is your Chrome interface, Latin or Cyrillic? Try running navigator.languages in the Console. If it is unknown for sure, start with just sr and Cyrillic, because https://chrome.google.com/webstore/category/extensions?hl=sr shows Cyrillic. Then try launching Chrome with different language code flags that you will find in the internet, like sr-Latn, and see if it makes any difference to UI.

@kizule
Copy link
Contributor

kizule commented Jan 30, 2021

Hi @alexanderby. It shows "sr-Latn-RS". So looks like I should create sr for Cyrillic and sr-Latn-RS for Latin. Right?

@alexanderby
Copy link
Member Author

What is the full list? I think sr and sr-Latn should be enough, it matches the closest code when the part is missing.

@kizule
Copy link
Contributor

kizule commented Jan 30, 2021

What is the full list?

I'm not sure what you mean.

@alexanderby
Copy link
Member Author

@kizule I mean the result of navigator.languages, it should return multiple locales.

@kizule
Copy link
Contributor

kizule commented Jan 30, 2021

This?
["sr-Latn-RS", "sr-Cyrl-RS", "en", "en-GB", "en-US"]

@ghost
Copy link

ghost commented Feb 3, 2021

This?
["sr-Latn-RS", "sr-Cyrl-RS", "en", "en-GB", "en-US"]

@kizule yep, pretty sure its that

@Regnander
Copy link
Contributor

There are some strings in the mobile GUI that I cannot find in the English config file:

aaa

@Gusted
Copy link
Contributor

Gusted commented Apr 9, 2021

Hi @Regnander!

They are the preview of Dark Reader's v5 new UI. As it's the preview we haven't been able to add translation for this in the config as the UI is still getting modified and added elements. When we are going to use V5 as the default UI, we will be adding the strings in the translations config.

Regards,
Gusted

@hchiam
Copy link

hchiam commented May 4, 2021

I noticed that the developer tools popup isn't translated into French for the desktop version. I'd be interested in helping out, but wanted to check first. Based on PR #3237, it looks like all I'd have to do is use getLocalMessage in the tsx with text matching the respective .config @some_translation_key.
Translated: translated-main-popup versus: not-translated-dev-popup

@Gusted
Copy link
Contributor

Gusted commented May 4, 2021

I noticed that the developer tools popup isn't translated into French for the desktop version. I'd be interested in helping out, but wanted to check first. Based on PR #3237, it looks like all I'd have to do is use getLocalMessage in the tsx with text matching the respective .config @some_translation_key.

Correct. See the How to add a new translation section of the original message of this issue.

@Gusted
Copy link
Contributor

Gusted commented May 12, 2021

@turkyden Don't use this issue for advertising.

@Gitleptune
Copy link

I will add Bulgarian (bg), PR should be open later today!

@NguyenASang
Copy link
Contributor

NguyenASang commented Oct 3, 2021

Is there any Viet Nam translation ? If not, I will add that :D

@IverCoder
Copy link
Contributor

IverCoder commented Oct 18, 2021

I just added a Filipino translation, please check it out on #7116. Thanks 😊😁

@mauriallegrettiswnat
Copy link
Contributor

Hello. I'm going to add a new translation for es_419 Spanish (Latin America and Caribbean)

@alexanderby
Copy link
Member Author

Hi @mauriallegrettiswnat, that would be wonderful. Please use es-419.config file name. You can see the other Spanish translation for reference

@MikaelFangel
Copy link
Contributor

MikaelFangel commented Apr 7, 2023

I'm going to add da-DK.config for the Danish translation.

EDIT:
Added with #11064 and #11083

@philipp-schuetz
Copy link
Contributor

In the handle '@support_out_work' in the translation files (line 217) is a typo. I should probably be '@support_our_work' instead. Is this something (easily) fixable or would changing this involve a whole lot more work because all translations will break?

@GemedetAdept
Copy link

I'm unfamiliar with locale files, but I want to help. I would like to add Chamorro (CHamoru), but given the diminutive size of the language, it isn't on Chrome's locale list (and I imagine it won't be added, at least not any time soon.)

Would it be possible to add CHamoru as an option, or does this discrepancy make that an impossibility?

@alexanderby
Copy link
Member Author

alexanderby commented Dec 1, 2023

Hi @GemedetAdept. You can technically try. But I'm not sure it will work. Maybe you will be able to launch Chrome with the right language flag. Maybe it will work in Edge on Windows, they have more supported languages. But maybe no. Right now we have no technical ability for switching a language within the app, it depends on your browser UI language.

@GemedetAdept
Copy link

Thank you for the info, @alexanderby! I'm using Firefox but, as far as I have found, it doesn't have built-in support for Chamorro.

Maybe you will be able to launch Chrome with the right language flag.

I'll have to research into this for Firefox! I don't have much experience with browser launch & control tinkering (outside of simple API requests and libraries like Selenium), so this will be a good and practical learning experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests