Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔒 feat: password reset disable option; fix: account email error message #2327

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

🔒 feat: password reset disable option; fix: account email error message #2327

wants to merge 8 commits into from
+158 −34

Conversation

berry-13
Copy link
Collaborator

@berry-13 berry-13 commented Apr 5, 2024 •
edited

Summary

feat: Implement a disable option for password reset

fix: Resolve the error message regarding incorrect account email

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update

Testing

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.
  • New documents have been locally validated with mkdocs

@berry-13 berry-13 linked an issue Apr 5, 2024 that may be closed by this pull request
Enhancement: Option to disable password reset functionality entirely #2326
Open
1 task
@berry-13 berry-13 marked this pull request as ready for review April 5, 2024 19:49
@berry-13 berry-13 changed the title feat: password reset disable option; fix: account email leak 🔒 feat: password reset disable option; fix: account email leak Apr 5, 2024
@XHyperDEVX
Copy link
Contributor

Will only the option to reset the password be deactivated here or will the "Reset password" option also disappear from the UI?

@berry-13
Copy link
Collaborator Author

berry-13 commented Apr 5, 2024

Will only the option to reset the password be deactivated here or will the "Reset password" option also disappear from the UI?

wdym exactly? this disable the password reset from both frontend and backend

@XHyperDEVX
Copy link
Contributor

i mean if this hyperlink also disappears or if when you click on it only the message "password reset disabled" is displayed (because i only saw this in the code)
image

@berry-13
Copy link
Collaborator Author

berry-13 commented Apr 5, 2024

i mean if this hyperlink also disappears or if when you click on it only the message "password reset disabled" is displayed (because i only saw this in the code)

no no, also that button disappears when disabling the reset password

@danny-avila danny-avila changed the title 🔒 feat: password reset disable option; fix: account email leak 🔒 feat: password reset disable option; fix: account email error message Apr 6, 2024
@danny-avila
Copy link
Owner

@berry-13 tests failing?

@danny-avila
Copy link
Owner

@berry-13 Adjusting the existing, failing tests to match the new behavior looks pretty simple. Please work on this when you get the chance.

@danny-avila danny-avila added this to the v0.7.3 milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
LibreChat
Status: 🚧 On Going
Milestone
v0.7.3
Development

Successfully merging this pull request may close these issues.

Enhancement: Option to disable password reset functionality entirely
3 participants
@berry-13 @XHyperDEVX @danny-avila