Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 fix(openidStrategy): avatar not persistent #2065

Closed
wants to merge 6 commits into from

Conversation

berry-13
Copy link
Collaborator

Summary

fixed #2056

Change Type

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Testing

tested with AWS cognito

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.
  • New documents have been locally validated with mkdocs

@berry-13 berry-13 changed the title 🔧 fix(openidStrategy): fixed avatar not persistent 🔧 fix(openidStrategy): avatar not persistent Mar 11, 2024
api/strategies/openidStrategy.js Outdated Show resolved Hide resolved
@berry-13
Copy link
Collaborator Author

berry-13 commented Mar 12, 2024

wait, don't merge this PR

@berry-13 berry-13 marked this pull request as draft March 12, 2024 16:04
@berry-13
Copy link
Collaborator Author

berry-13 commented Apr 4, 2024

closing this since we should prioritize a more robust solution by addressing the current shortcomings in handling the avatar within OpenID. The current implementation is not optimal and requires improvement

@berry-13 berry-13 closed this Apr 4, 2024
@berry-13 berry-13 deleted the fix-opendid-bugs branch May 9, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Avatar with OIDC not persistent
2 participants