-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support float/double image width and height #39
Comments
Rounding should not cause any problem I think. The sizes are only used for specific samplers and for the neighborhood calculation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
Currently the python wrapper, see e.g. here:
graph-cut-ransac/src/pygcransac/src/gcransac_python.cpp
Lines 721 to 731 in 37f7469
only supports integer image sizes.
As far as I can tell, these are always cast to doubles, so it would make sense to support arbitrary numbers.
In my use case I have modified the intrinsics, and hence the "virtual" image sizes become doubles. I'm unsure if rounding these to integers pose any issues to the RANSAC loop, so would prefer to insert the exact values.
Although reading the code it seems these only control neighbourhood sizes so I guess rounding shouldnt be a big issue.
Best,
Johan
The text was updated successfully, but these errors were encountered: