Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support float/double image width and height #39

Open
Parskatt opened this issue Dec 6, 2022 · 1 comment
Open

Support float/double image width and height #39

Parskatt opened this issue Dec 6, 2022 · 1 comment

Comments

@Parskatt
Copy link

Parskatt commented Dec 6, 2022

Hi,

Currently the python wrapper, see e.g. here:

int findFundamentalMatrix_(
// The 2D-2D point correspondences
std::vector<double>& correspondences,
// The probabilities for each 3D-3D point correspondence if available
std::vector<double> &point_probabilities,
// Output: the found inliers
std::vector<bool>& inliers,
// Output: the found 6D pose
std::vector<double> &fundamental_matrix,
// The images' sizes
int h1, int w1, int h2, int w2,

only supports integer image sizes.

As far as I can tell, these are always cast to doubles, so it would make sense to support arbitrary numbers.

In my use case I have modified the intrinsics, and hence the "virtual" image sizes become doubles. I'm unsure if rounding these to integers pose any issues to the RANSAC loop, so would prefer to insert the exact values.

Although reading the code it seems these only control neighbourhood sizes so I guess rounding shouldnt be a big issue.

Best,
Johan

@danini
Copy link
Owner

danini commented Jul 4, 2023

Rounding should not cause any problem I think. The sizes are only used for specific samplers and for the neighborhood calculation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants