-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
instances > X OR threshold > Y #66
Comments
I think that threshold defines how deep the algorithm looks for repetitions, not how complex is the analysed part of code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, just stumbled over this and I love it!
I'm looking into using it as part of an automatic code-review process. I tend to only consider code unnecessary duplication when it is either repeated more than twice or it has a high complexity (which if I understand the threshold param correctly, would for me be something like a threshold of 40).
Or to put in simple english terms: If something is repeated twice, I only consider it an unelegant duplication when the repeated code is complex.
Do you see value in having such an option?
The text was updated successfully, but these errors were encountered: