Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorites are tracked at cipher level rather than on a per-user basis #885

Closed
jjlin opened this issue Mar 1, 2020 · 0 comments · Fixed by #1106
Closed

Favorites are tracked at cipher level rather than on a per-user basis #885

jjlin opened this issue Mar 1, 2020 · 0 comments · Fixed by #1106

Comments

@jjlin
Copy link
Contributor

jjlin commented Mar 1, 2020

Currently, whether a cipher is a "favorite" is a property of the cipher itself, but it should probably be tracked similarly to folders, with a separate "favorites" table that maps users to ciphers. Otherwise, for a shared cipher, when one user sets a cipher as a "favorite", it automatically becomes every other user's favorite too, which probably isn't the intended behavior.

Also, when changing the "favorite" property, the cipher update time probably shouldn't be updated (similar to #884).

@jjlin jjlin changed the title Favorites are tracked at cipher level rather than user/cipher level Favorites are tracked at cipher level rather than on a per-user basis Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant