Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context menu? #2

Open
braco opened this issue Feb 2, 2016 · 4 comments
Open

Context menu? #2

braco opened this issue Feb 2, 2016 · 4 comments

Comments

@braco
Copy link

braco commented Feb 2, 2016

Why not put the activation icon in the context menu on textareas? (right-click, ctrl-click, etc)

Could eliminate the need for the toolbar icon, which seems out of place.

@danhper
Copy link
Owner

danhper commented Feb 2, 2016

I use a shortcut to activate the extension.
I agree the toolbar icon is not really useful,
but I think in this case, it would be good to have a default shortcut.
Do you think that a context menu could be more useful than a simple shortcut?

@braco
Copy link
Author

braco commented Feb 2, 2016

I think so, it would target the element and seems obvious that you're performing an action there.

And maybe some action could be performed if the element loses focus?

@danhper
Copy link
Owner

danhper commented Feb 2, 2016

I see. I agree this use of the contextual menu seems more natural.
I am going to change this, thank you for the feedback.

I would however rather not do anything when the element loses the focus,
as for example in Github, one would press the preview button and
make some modifications afterwards, so I think it could interfere
with a normal workflow.

@braco
Copy link
Author

braco commented Feb 3, 2016

Good point! Maybe the DOM location could be stored and focus could be recaptured when the user begins typing in Atom again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants