Remove check for "puts" when parsing Dangerfile

[lukeredpath]

This check is pretty annoying and naive - it will fail if I have a variable called inputs for example.

Also, I want to use puts in my Dangerfile to print out information to help debug and test my Dangerfile scripts in both local testing and CI output.

danger/lib/danger/danger_core/dangerfile.rb

Line 197 in 89923b3

ui.puts "You used `puts` in your Dangerfile. To print out text to GitHub use `message` instead"

[orta]

I'm open to an env var hiding the output

[lukeredpath]

Potential fix here: master...lukeredpath:patch-1

However, perhaps a better solution would be for the DSL to provide some kind of debug function that acts as a proxy to puts that won't get picked up by this check. That way you wouldn't be calling it by accident but its there if you want to output some debug statements to STDOUT.

[manicmaniac]

For debugging purpose, you can use p or print instead of puts in order to avoid warnings.

IMO if you really want to use puts, introducing a new environment variable would be the first option.

[manicmaniac]

BTW I agree with you that the current implementation is a bit naive and it may cause false-positive.

My rough idea is:

1. Properly parsing contents with Ruby language parser (e.g. Ripper)

• pros: it doesn't break anything
• cons: overengineering

2. Overriding Danger::Dangerfile#puts

• pros: easy
• cons: may break existing plugins