Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: no implicit conversion of String into Integer #1322

Open
iamarjun opened this issue Sep 21, 2021 · 2 comments
Open

TypeError: no implicit conversion of String into Integer #1322

iamarjun opened this issue Sep 21, 2021 · 2 comments

Comments

@iamarjun
Copy link

Report

Run bundle exec danger in travis

What did you expect to happen?

To run successfully

What happened instead?

image

Your Environment

  • CI - Travis
  • Danger - 8.2.3
  • Ruby - 2.7.4
@orta
Copy link
Member

orta commented Sep 21, 2021

Can you say how you've tried to debug it?

@iamarjun
Copy link
Author

Hi @orta I tried going through the danger code to understand things better.
This method

def self.from_github(comment)

which gets called at this point
danger_comments = pr_comments.select { |comment| Comment.from_github(comment).generated_by_danger?(danger_id) }

also, I googled when this error is thrown https://ruby-doc.org/core-2.7.1/TypeError.html
not sure what the problem is
def self.from_github(comment) self.new(comment["id"], comment["body"]) end
Maybe the comment is an array of integers and not strings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants