Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab - Danger is not deleting outdated inline comments #1315

Open
FabioCZ opened this issue Aug 2, 2021 · 1 comment
Open

Gitlab - Danger is not deleting outdated inline comments #1315

FabioCZ opened this issue Aug 2, 2021 · 1 comment

Comments

@FabioCZ
Copy link

FabioCZ commented Aug 2, 2021

Report

What did you do?

Let's say that a Dangerfile posts an in-line comment to Gitlab:
warn("Please do not do xyz in this file", file: some_file_path, line: some_line_number)

The merge requests author later pushes another commit that fixes this violation, causing the Dangerfil to not call warn(...) with the same inline comment. The original inline comment is out of date and should be deleted.

I've tried running the Danger script with --remove-previous-comments and --new-comment flags, but that doesn't seem to alleviate the issue.

What did you expect to happen?

The outdated in-line comment should be deleted by Danger

What happened instead?

The outdated in-line comment stays on Gitlab and is not deleted by danger.

Danger is managing to delete non-inline (i.e. regular) comments just fine, it's only the inline comments that seem to be a problem.

Your Environment

Gitlab enterprise repo + Gitlab CI
Danger 8.3.1

# please paste here, with 2-space identation, thank you!
@orta
Copy link
Member

orta commented Aug 3, 2021

Sure, that sounds like a legit bug - you're welcome to look into it 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants