You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Let's say that a Dangerfile posts an in-line comment to Gitlab: warn("Please do not do xyz in this file", file: some_file_path, line: some_line_number)
The merge requests author later pushes another commit that fixes this violation, causing the Dangerfil to not call warn(...) with the same inline comment. The original inline comment is out of date and should be deleted.
I've tried running the Danger script with --remove-previous-comments and --new-comment flags, but that doesn't seem to alleviate the issue.
What did you expect to happen?
The outdated in-line comment should be deleted by Danger
What happened instead?
The outdated in-line comment stays on Gitlab and is not deleted by danger.
Danger is managing to delete non-inline (i.e. regular) comments just fine, it's only the inline comments that seem to be a problem.
Your Environment
Gitlab enterprise repo + Gitlab CI
Danger 8.3.1
# please paste here, with 2-space identation, thank you!
The text was updated successfully, but these errors were encountered:
Report
What did you do?
Let's say that a Dangerfile posts an in-line comment to Gitlab:
warn("Please do not do xyz in this file", file: some_file_path, line: some_line_number)
The merge requests author later pushes another commit that fixes this violation, causing the Dangerfil to not call
warn(...)
with the same inline comment. The original inline comment is out of date and should be deleted.I've tried running the Danger script with
--remove-previous-comments
and--new-comment
flags, but that doesn't seem to alleviate the issue.What did you expect to happen?
The outdated in-line comment should be deleted by Danger
What happened instead?
The outdated in-line comment stays on Gitlab and is not deleted by danger.
Danger is managing to delete non-inline (i.e. regular) comments just fine, it's only the inline comments that seem to be a problem.
Your Environment
Gitlab enterprise repo + Gitlab CI
Danger 8.3.1
# please paste here, with 2-space identation, thank you!
The text was updated successfully, but these errors were encountered: