Feature: Expose --id to rules

[glensc]

I want to get the value of danger ci --id to use in rules.

The intent is to run danger twice on CI pipeline, first time early to report coding errors, second time late to grab any artifacts from CI jobs and format them as comments.

The property itself is here:

• danger-js/source/commands/ci/runner.ts

  Line 66 in 0b2c1d3

  dangerID: app.id || "Danger",

[glensc]

for now i'll use environment variable in my rules:

export const DANGER_ID = process.env.DANGER_ID || 'Danger';

but that's just duplicating the same thing, I need to set the env and need to pass --id arg when executing danger second time on the pipeline

[glensc]

Ideas, guides? on how to implement this?

[fbartho]

We run two different Dangerfiles in our repo, so we don't need access to the ID within a single Dangerfile. Is that technique worthwhile for you @glensc?

danger ci --id "$1" --dangerfile "$DANGER_FILES_DIR/$1.ts" where $1 is the name of the file we're executing.

This then lets us easily trigger different danger files from different events or steps in a Github Actions Workflow, and not have them trip over each other.

[orta]

Feels like a field which could be available in the main danger export to me

[glensc]

@orta, so something here:

• danger-js/source/runner/jsonToDSL.ts

  Lines 54 to 67 in 0b2c1d3

  	return {
  	git,
  	// Strictly speaking, this is a lie. Only one of these will _ever_ exist, but
  	// otherwise everyone would need to have a check for GitHub/BBS in every Dangerfile
  	// which just doesn't feel right.
  	github: github!,
  	bitbucket_server: bitbucket_server!,
  	bitbucket_cloud: bitbucket_cloud!,
  	gitlab: gitlab!,
  	utils: {
  	sentence,
  	href,
  	},
  	}

just add root level dangerId there? or as some structure? or under utils?

[orta]

I think dangerID in there would be 👍🏻 (utils is for functions IMO)