Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃З FEATURE REQUEST: Sortable My Shortcuts #747

Open
haideralipunjabi opened this issue Oct 23, 2022 · 7 comments
Open

馃З FEATURE REQUEST: Sortable My Shortcuts #747

haideralipunjabi opened this issue Oct 23, 2022 · 7 comments

Comments

@haideralipunjabi
Copy link

Feature Request

Make the Custom / My Shortcuts list sortable

Description

Each item in the My Shortcuts list will have two buttons, to move the item up or down.

If possible, I would like to contribute and code this.

@idoshamun
Copy link
Member

Hi @haideralipunjabi,

Thanks for the suggestion. Let me check internally. We might need to provide you with a design

@haideralipunjabi
Copy link
Author

Any update on this?

@idoshamun
Copy link
Member

Sorry for the late response @haideralipunjabi.
Our design team will provide the design for it but it might take some time as we're pretty busy lately

@sshanzel
Copy link
Member

sshanzel commented Dec 4, 2023

Hi @haideralipunjabi, our design team has come up with draggable behavior for our user input. More details can be found in the Sketch link below. Let me know if you are still interested in this. This would require modifications with our TextField input where dragging events should be supported.

https://www.sketch.com/s/2549ccf9-b98c-413f-96fb-81b05b59e65f/a/3oEM91Z

@haideralipunjabi
Copy link
Author

The designs look perfect. Although I believe I wouldn't be able to focus on this immediately so you can assign this to someone else.

@sshanzel
Copy link
Member

sshanzel commented Dec 5, 2023

The designs look perfect. Although I believe I wouldn't be able to focus on this immediately so you can assign this to someone else.

All cool! We can keep this open for anyone to take. Your thought of having this sort feature is already great enough of a contribution and we want to thank you for it 馃檶

@ghost
Copy link

ghost commented Jan 24, 2024

@sshanzel I am here to contribute to this project. However, I would appreciate it if you could provide me with a link to the folder containing the files for this specific task. Aside from that, I have a few questions about the design to avoid future misunderstanding. As shown here, when the user removes an element from the box, other icons adjust, but what about the element? Should it be deleted or moved to the very end of the list?
image
And the second question, can I get a brief about this part?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants