Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 BUG: Wrong custom shortcuts icons #725

Open
lior21 opened this issue Sep 30, 2022 · 1 comment
Open

馃悰 BUG: Wrong custom shortcuts icons #725

lior21 opened this issue Sep 30, 2022 · 1 comment

Comments

@lior21
Copy link

lior21 commented Sep 30, 2022

馃悰 Bug Report

What went wrong? 馃

The current icons service that is used for showing the custom shorcuts icons in a new tab, not returning the right icons in some cases.
It looks like an issue in the 3rd party icons service, but it affects the daily.dev new tab.
The icons are important especially since there is no other way to recognize the website in the custom link (like a title next to the icon)

Expected Behavior

The custom icons in a new tab should look the same as in the default browser's new tab.
This is how the icons look in the default browser's new tab (not daily.dev's tab):
image

Actual Behavior

The custom icons looks different. Most of google services icons are showing google's icon instead of the specific service icon:
image

Steps to Reproduce Issue

add photos.google.com to your custom shortcuts. the expected icon is this one:
image
but the actual icon is
image

Solution

Switch to another 3rd party icons service

Environment

The extension's new tab

Operating System

Windows 10

Version of Daily

3.16.16

Browser

Edge/Chrome

@lior21 lior21 changed the title 馃悰 BUG: Wrong custom links icons 馃悰 BUG: Wrong custom shortcuts icons Oct 1, 2022
@idoshamun
Copy link
Member

Hi @lior21,

We're indeed using a third-party service for it.
https://github.com/mat/besticon

We'll try to find our way around it and see how we can fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants