Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed bahavior upgrading from 0.8.0 to 0.8.1 #303

Open
tilo opened this issue Mar 23, 2024 · 0 comments
Open

Changed bahavior upgrading from 0.8.0 to 0.8.1 #303

tilo opened this issue Mar 23, 2024 · 0 comments

Comments

@tilo
Copy link

tilo commented Mar 23, 2024

looks like the API for PhoneLib changed from version 0.8.0 to 0.8.1

before you could do this:

phone = Phonelib.parse(phone_number, ["US", "CA"])

now you have to do this:

phone = nil
phone ||= Phonelib.parse(phone_number, "US")
phone ||= Phonelib.parse(phone_number, "CA")
  • such a change in behavior should be caught by failing tests in PhoneLib
    -> there was no test coverage
  • any change in behavior should rev-up more than just the last digit of the version
    -> see https://semver.org/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant