Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing geocoding data for country calling code #151

Open
sheena-gygax opened this issue Feb 11, 2019 · 2 comments
Open

Missing geocoding data for country calling code #151

sheena-gygax opened this issue Feb 11, 2019 · 2 comments
Labels
missing validation data data for some prefix/country is missing in the souce

Comments

@sheena-gygax
Copy link

sheena-gygax commented Feb 11, 2019

Phone numbers with area code '227' are not valid:

    phone = "227-220-1449"
    Phonelib.parse(phone).valid?

returns false

@sheena-gygax
Copy link
Author

sheena-gygax commented Feb 14, 2019

I tried updating data as suggested in #150, but still says the number is not valid:

2.4.1 :003 > Phonelib.valid? "2272383291"
 => false
2.4.1 :004 > Phonelib.valid_for_country? "2272383291", "US"
 => false

@daddyz
Copy link
Owner

daddyz commented Mar 6, 2019

@sheena-gygax Hi, original google libphonenumber does not recognize 227. Their regex says 22[03-589] which does not include 227. You can check it here and open an issue for them. Once they will implement this change, I will be able to update the data and phone will be validated as valid.

@daddyz daddyz added the missing validation data data for some prefix/country is missing in the souce label Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing validation data data for some prefix/country is missing in the souce
Projects
None yet
Development

No branches or pull requests

2 participants