Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusion to F-Droid main repository #1043

Open
ClockGen opened this issue Feb 29, 2024 · 5 comments
Open

Inclusion to F-Droid main repository #1043

ClockGen opened this issue Feb 29, 2024 · 5 comments
Labels
Build process Meta issues not related to the app but the project / gradle, i.e. building it. enhancement New feature, request, improvement or optimization

Comments

@ClockGen
Copy link

ClockGen commented Feb 29, 2024

Hello, I've been working on getting to build SDMain-SE on F-Droid infrastructure. The inclusion process is similar to your other app (Capod), which is already in F-Droid, however everything seems to be already covered in #755.

The app builds and verifies fine (it's in my private branch for now), but I need your permission to include it in F-Droid.

Another thing, can you please change the apk naming scheme and remove the commit hash suffix, so it'd look like this:
eu.darken.sdmse-v0.21.0-beta0-2100000-FOSS-BETA.apk
(same naming scheme as Capod). This is needed to allow F-Droid to retrieve your apk for reproducible builds.

I can also work on getting your other apps (permission pilot and octi) to F-Droid, if you want.

@ClockGen ClockGen added enhancement New feature, request, improvement or optimization triage This ticket needs to be sorted and labeled. labels Feb 29, 2024
@d4rken d4rken added Build process Meta issues not related to the app but the project / gradle, i.e. building it. and removed triage This ticket needs to be sorted and labeled. labels Mar 12, 2024
@d4rken
Copy link
Member

d4rken commented Mar 14, 2024

As far as I understood, it's not possible to include SD Maid 2/SE in the main F-Droid repo because it has the "anti-feature" NonFreeAssets.

Code is GPLv3, but not all assets are (see README.md). I currently have no plans to change that, sorry.

I'm fine with it just being available in @IzzySoft's repo:
https://apt.izzysoft.de/fdroid/index/apk/eu.darken.sdmse

FYI, there also appears to be an open PR here:
https://gitlab.com/fdroid/rfp/-/issues/2533

Side-note: CAPod is included in F-Droid, but it has the same license-caveat/anti-feature. That might have been a mistake? Or I'm mistaken with the anti-feature requirements of the main repo 🤔

@IzzySoft
Copy link

@d4rken NonFreeAssets is just an anti-feature, not a show-stopper, at F-Droid. the corresponding RFP you've linked was not rejected – it's just nobody working on it.

That said, I'm fine keeping your app in my repo 😄

@ClockGen
Copy link
Author

ClockGen commented Mar 14, 2024

As Izzy said, antifeatures don't prevent apps from being included in F-Droid.

t's just nobody working on it.

Well, I'm working on it, that's why I ask for permission to publish it in main repo. It currently builds and verifies fine, I just need the attached apk to be renamed (as I noted in the original issue post) so F-Droid can retrieve it for future updates.

@shuvashish76
Copy link

shuvashish76 commented Apr 2, 2024

Anti-Features are just for transparency they're not against F-Droid's inclusion policy.

@ClockGen @d4rken Instructions are mentioned here.

@linsui
Copy link

linsui commented Apr 4, 2024

it's just nobody working on it

It's not nobody working on it. Everyone is waiting for the decision here. @d4rken What's you decision? Do you want us to include your app? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build process Meta issues not related to the app but the project / gradle, i.e. building it. enhancement New feature, request, improvement or optimization
Projects
None yet
Development

No branches or pull requests

5 participants