Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More info under App Details #122

Open
TheRealMystic opened this issue Jul 30, 2022 · 9 comments
Open

More info under App Details #122

TheRealMystic opened this issue Jul 30, 2022 · 9 comments
Labels
enhancement New feature or request
Milestone

Comments

@TheRealMystic
Copy link
Collaborator

TheRealMystic commented Jul 30, 2022

Can you include the following additional info in the App Details section:

iMarkup_20220730_121731

If you do, then this has to come right underneath the 1st box, i.e. above the box that shows if Clones/ SharedUserID are present. This will keep the UI consistent for all apps.

@TheRealMystic TheRealMystic added the enhancement New feature or request label Jul 30, 2022
@d4rken
Copy link
Member

d4rken commented Jul 30, 2022

Hm feels like scope creep as it's not relevant to any permission related behavior.

To get app sizes, we'll also need to ask the user for usage stats permission.
RAM information is not really available.
Battery and data usage maybe.

@d4rken d4rken added this to the Blue Sky milestone Jul 30, 2022
@TheRealMystic
Copy link
Collaborator Author

TheRealMystic commented Jul 30, 2022

This is the App Details page, so having all the info about it there is a good thing. User doesn't have to navigate through multiple pages in System Settings to see the info he wants: a primary purpose for this app. 😉

When an app doesn't have internet permission in its code, it feels very safe to grant everything it asks for. 🤣🤣

@TheRealMystic
Copy link
Collaborator Author

TheRealMystic commented Jul 30, 2022

This is how an optional permission should be implemented:

Optional Permission Implementation

The app doesn't request Usage Acces permission anywhere during setup. It only shows the message under the feature where that permission is necessary. This is a very clean way of implementing an optional feature. If the user wants that feature, he clicks on that space and grants the requested permission.

Many apps simply close where an optional permission isn't granted. That's very poor implementation (assuming there is nothing more to it). For example, a music app asking for microphone permission. Such apps get immediately uninstalled from my device.

@d4rken
Copy link
Member

d4rken commented Jul 30, 2022

navigate through multiple pages in System Settings to see the info he wants: a primary purpose for this app. wink

The apps purpose is "permissions" though, do these additional infos help with anything regarding permissions?
🤔

You have to think about it this way:
Unless others are contributing code in major ways, any feature, improvements and fixes require my time.
Increasing the code with additional features increases the amount of code and thus amount of work required to maintain the app. So by extending the app scope and adding features that are not part of the primary app mission we are implicitly reducing the amount of time that is spend on core features.

We can put this in Blue Sky, if suddenly many people show interest in this functionality, it can be repriotized.

When an app doesn't have internet permission in its code, it feels very safe to grant everything it asks for. roflrofl

I can trick the user into opening a link and then send the data to a server using the URL 😨

@TheRealMystic
Copy link
Collaborator Author

TheRealMystic commented Jul 30, 2022

The apps purpose is "permissions" though, do these additional infos help with anything regarding permissions? 🤔

This is called 'evolution'. And it isn't something completely irrelevant to that section: App Details. Version info, install info, build info too are not part of permissions, but these are useful info at a glance.

You have to think about it this way: Unless others are contributing code in major ways, any feature, improvements and fixes require my time. Increasing the code with additional features increases the amount of code and thus amount of work required to maintain the app. So by extending the app scope and adding features that are not part of the primary app mission we are implicitly reducing the amount of time that is spend on core features.

I fully agree. May be I'll start learning Kotlin instead of waiting for retirement. 🤣🤣

We can put this in Blue Sky, if suddenly many people show interest in this functionality, it can be repriotized.

Sure. Thanks.

When an app doesn't have internet permission in its code, it feels very safe to grant everything it asks for. roflrofl

I can trick the user into opening a link and then send the data to a server using the URL 😨

Haan? 😱😱

@d4rken
Copy link
Member

d4rken commented Jul 30, 2022

This is called 'evolution'. And it isn't something completely irrelevant to that section: App Details. Version info, install info, build info too are not part of permissions, but these are useful info at a glance.

Permissions change between versions so version info is directly related.
Which permissions an app is granted also depends on the API versions, i.e. apps targeting older APIs may get "legacy" status and be granted a permission by default without the user being asked.

@TheRealMystic
Copy link
Collaborator Author

TheRealMystic commented Jul 30, 2022

This is called 'evolution'. And it isn't something completely irrelevant to that section: App Details. Version info, install info, build info too are not part of permissions, but these are useful info at a glance.

Permissions change between versions so version info is directly related. Which permissions an app is granted also depends on the API versions, i.e. apps targeting older APIs may get "legacy" status and be granted a permission by default without the user being asked.

If data consumed shows as zero: it can be inferred that the app does not have internet permission, and probably doesn't have a SharedUserID too.

If battery consumption is low or zero: it can be inferred that the app does not have permission to use battery in the background, i.e. it is restricted from running in the background.

As you can see, these information are linked to permissions granted to apps.

@d4rken
Copy link
Member

d4rken commented Jul 30, 2022

That is not how it works.

If data consumed shows as zero: it can be inferred that the app does not have internet permission, and probably doesn't have a SharedUserID too.

The only thing that can be inferred is that is has not caused any network traffic YET in ways that are monitored by the system.

If battery consumption is low or zero: it can be inferred that the app does not have permission to use battery in the background, i.e. it is restricted from running in the background.

Or hasn't run yet, or is below the minimums, or caused battery drain in a way that isn't tracked. Or caused battery drain that was falsely attributed.

@vertigo220
Copy link

I could see battery and data use info being somewhat relevant, not because it relates at all to permissions, but rather allows you to see what a particular app is up to. This app allows you to see what it can do, and therefore fulfills its intended purpose, this addition would also allow you to see what it is doing. App size and RAM usage is totally irrelevant to this, though. This could certainly be nice and potentially useful, but at the same time is definitely beyond the scope, and there are many other, and better, ways to get this info. For example, a battery app is going to give much better info about an app's usage than this app would. And especially considering all you have to do to get all this info and more is tap the icon at the top-right to open the system app info page, I have to agree there are better things to spend development time on.

@TheMysticS I hope you don't take offense, but there are currently 28 open issues, and 23 of those are from you making requests, and you think every one of those requests is extremely important, and almost every one I've looked at, you've appealed extensively and even argued for them and been insulting toward the dev. It's fine to make requests and to even "argue" for them, but you shouldn't get argumentative with or insulting to the person you're making the request of (or others). And you need to understand they are one person doing this likely with very little compensation and therefore in their spare time, and each request takes a while to do, often much longer than you seem to think. Some devs would get mad simply for the amount of issues you've created, and @d4rken seems, to their credit, to be very receptive, so you should give them credit for that and try to focus on the issues you find more important and realize not all of them are likely to happen, and certainly not as quickly as I imagine you'd like. And while I suspect you were being sarcastic about learning Kotlin, that's not only probably the only way some/many of your requests might be added, but it would help you learn how many of these things are not so simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants