Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize highlighter color #889

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Customize highlighter color #889

wants to merge 3 commits into from

Conversation

MooDySmiles
Copy link

This PR adds a config to the TextHighlighter module which enables the user to define a custom set of hex colors as an array of strings as options to highlight text.

If the config is undefined or an empty array resorts to the default set of colors already present in the code.

The PR also adds a method in the reader.ts file to directly change the highlight color, giving the user the option to handle the highlighting color via external elements and not the one defined by the TextHighlighter module.

Closes #855

fix: compare userSettings textAlignment assigns to textAlignmentsValu…
feae038 
…es indexes instead of elements; adds textAlignmentValue to IUserSettings and adds if statement checking for that property when applyingUserSettings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aferditamuriqi aferditamuriqi Awaiting requested review from aferditamuriqi aferditamuriqi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possibility to customize highlighter color via API
1 participant
@MooDySmiles