Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefix css classes, use ID selectors when possible #679

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

prefix css classes, use ID selectors when possible #679

wants to merge 6 commits into from

Conversation

gotson
Copy link
Contributor

@gotson gotson commented Nov 23, 2023

This PR addresses #641 by prefixing some CSS classes with r2d2bc-.

It also removes some of the logic to find HTML elements by CSS classes, and instead uses ID selectors.

Closes #641

@gotson
Copy link
Contributor Author

gotson commented Nov 24, 2023

i've added one more commit to fix some CSS conflicts coming from the TTS styles. Since the project does not use scoped styles, the stylesheets impact the whole application, and thus applying very generic styles like input[type=checkbox] is not a good practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aferditamuriqi aferditamuriqi Awaiting requested review from aferditamuriqi aferditamuriqi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

css classes conflict with popular framework
1 participant
@gotson