Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http://localhost has no base route for drag and drop recipe #448

Open
prat3ik opened this issue Mar 21, 2020 · 5 comments · May be fixed by #455
Open

http://localhost has no base route for drag and drop recipe #448

prat3ik opened this issue Mar 21, 2020 · 5 comments · May be fixed by #455

Comments

@prat3ik
Copy link

prat3ik commented Mar 21, 2020

I have cloned the project and did install all dependencies from the root directory using npm install then as a part of testing I did move to /examples/testing-dom__drag-drop (cd ./examples/testing-dom__drag-drop) and executed npm start(screenshot1) command to start the localhost, but it gave me an error(screenshot2):

screenshot1:
image

screenshot2:
image

Node version: 12.14.0
NPM version: 6.13.4

Is there something I am missing?
@jennifer-shehane
Copy link
Member

Yah, it seems this recipe does not have an index.html so there is no handling of visiting http://localhost by itself. You have to explicitly visit the pages you want like http://localhost:7071/puzzle.html or http://localhost:7071/basketball.html

We could add an index.html that just contains links to the other pages to reduce confusion. We'd be open to a PR for this.

@jennifer-shehane jennifer-shehane changed the title localhost seems not working with Node v12.14.0 http://localhost has no base route for drag and drop recipe Mar 23, 2020
@prat3ik
Copy link
Author

prat3ik commented Mar 23, 2020

Thank you @jennifer-shehane !
More than happy to open PR for this.

@prat3ik
Copy link
Author

prat3ik commented Mar 23, 2020

I have added simple index.html:
image

But when I am pushing it's giving me an error:
image

Is there something I need to take care of ?

@jennifer-shehane
Copy link
Member

You'll need to create a fork the repo and open a PR. We don't allow push access to outside contributors.

@prat3ik
Copy link
Author

prat3ik commented Mar 25, 2020

Thanks, I have raised PR: #455

@prat3ik prat3ik linked a pull request Mar 27, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

index.html added for testing-dom__drag-drop example prat3ik/cypress-example-recipes
2 participants
@jennifer-shehane @prat3ik