WIP: most-run to support @most/core #881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(most-run): uses @most/create that isn't officially supported. Is backwards compatible. Uses @most/create that isn't officially supported, I imagine in terms of it handling simultaneously @Most and mostjs with it's backwards compatibility. Untested since it relies on run to support unadapt, a method replace xs.fromPromise in run to support @Most. Doesn't add tests to run, making sure that drivers actually get proper sources. There're some warning in most@ as to how custom stream creators should be made, which I just assume create package respects as the warning's meaning was beyond me. BREAKING CHANGE: none ISSUES CLOSED: cyclejs#845
|
It hypothetically may not actually stop running streams provided to xs.fromObservable. |
janat08
changed the title
|
besides the above point the conversion works, but it doesn't within context of cyclejs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(most-run): uses @most/create that isn't officially supported. Is backwards compatible.
Uses @most/create that isn't officially supported, I imagine in terms of it handling simultaneously
@Most and mostjs with it's backwards compatibility. Untested since it relies on run to support
unadapt, a method replace xs.fromPromise in run to support @Most. Doesn't add tests to run, making
sure that drivers actually get proper sources. There're some warning in most@ as to how custom
stream creators should be made, which I just assume create package respects as the warning's meaning
was beyond me.
BREAKING CHANGE:
none
ISSUES CLOSED: #845
pnpm run commitinstead ofgit commit