-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed Breaking Change: PR #796, fix(dom): do not duplicate root element with no id #798
Comments
3 tasks
Very good summary, I was reluctant to agree to this change, but now I do |
Yep, I'm on the same page. Good job! (I'm late to go through all the issues, but I eventually do 😃) I think we could even include your summary in the release notes. Or if not, then a link to this issue. |
@issuehuntfest has funded $40.00 to this issue. See it on IssueHunt |
@bloodyKnuckles has submitted a pull request. See it on IssueHunt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PR #796: fix(dom): do not duplicate root element with no id
It was discovered when targeting the HEAD element, discussed here, that the DOM driver is duplicating the target container when no ID is provided with it. For example, targeting the HEAD tag:
...currently results in:
This, of course, is not limited to the HEAD tag but any same-name tag that has an ID provided to neither the target container nor the root VDOM element. For example, given:
...and
...currently results in:
Right now this can be overcome by including an empty string ID with the root VDOM object (whether
head
ormain
, ordiv
...):This breaking change DOES NOT affect situations where the target container and root VDOM have different tag names. Given the fix proposed in PR #796, and:
...and
...results in:
And this breaking change DOES NOT affect situations where the target container OR root VDOM have an ID set. Given the fix proposed in PR #796, and:
...and
...results in:
...and
...results in:
This breaking change DOES affect situations where the target container and root VDOM have the same tag name and neither have an ID set. For example, given the fix proposed in PR #796, and:
...and
...results in:
...compared to WITHOUT the proposed fix results in:
The text was updated successfully, but these errors were encountered: