Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Add regex pattern to remove trailing backslash #327

Closed
wants to merge 3 commits into from

Conversation

NaomiHaser
Copy link

@NaomiHaser NaomiHaser commented Aug 13, 2021

What does this PR do?

Uses regex pattern to remove trailing backslashes in init url.

What ticket does this PR close?

Resolves #318

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

@NaomiHaser NaomiHaser requested a review from a team as a code owner August 13, 2021 18:15
@rpothier
Copy link
Contributor

Is there a bug associated with this?

@codeclimate
Copy link

codeclimate bot commented Aug 13, 2021

Code Climate has analyzed commit 8fe4be7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 51.1% (-0.1% change).

View more on Code Climate.

@imheresamir imheresamir marked this pull request as draft August 25, 2021 05:26
@imheresamir
Copy link

Needs unit tests and discussion around approach and desirability of this bug fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Trailing slashes on appliance URLs break CLI functionality
4 participants